Refactor zha/async_device_initialized()#16485
Merged
balloob merged 1 commit intohome-assistant:devfrom Sep 12, 2018
Merged
Conversation
Leverage endpoint.model and endpoint.manufacturer properties
homeassistant
added
integration: zha
small-pr
ghost
added
the
balloob
approved these changes
Sep 12, 2018
Member
|
Thanks for all your work on ZHA 👍 I see you're handling manufacturer/brand. Would you be interested in adding a PR for ZHA to make it part of the device registry? More info here |
Contributor
Author
|
I'll be looking into that. Some physical ZHA devices are multifaceted and device concept aligns with that nature of zha devices quite well. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Leverage endpoint.model and endpoint.manufacturer properties instead of reading manufacturer/model attributes.
Zigpy PR#56 stores manufacturer and model information as endpoint attributes. No need to read those, so no need for _discovery_endpoint_info() method.
Checklist:
tox. Your PR cannot be merged unless tests pass